This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
gps: vcs: dedupe git version list #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's an example for more context: |
|
|
|
ok, read this through. yeah, i totally just messed this up my first time through 😄 |
sdboyer
approved these changes
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
func (s *gitSource) listVersionscan return duplicate mappings (same tag to multiple revisions), and we were dependent on both the order of the slice elements and the implementation details offunc (c *singleSourceCacheMemory) setVersionMapto de-dupe what actually get's used (the cache stores amapinternally, so the last element is the one that wins).This PR changes the way the list is built, so that duplicates are replaced.